Thread (15 messages) 15 messages, 11 authors, 2025-10-21

Re: [PATCH] dt-bindings: Fix inconsistent quoting

From: Rob Herring <robh@kernel.org>
Date: 2025-10-16 11:46:17
Also in: linux-arm-kernel, linux-clk, linux-devicetree, linux-gpio, linux-iio, linux-media, linux-pci, linux-phy, lkml

On Thu, Oct 16, 2025 at 2:57 AM Geert Uytterhoeven [off-list ref] wrote:
Hi Rob,

On Thu, 16 Oct 2025 at 01:20, Rob Herring (Arm) [off-list ref] wrote:
quoted
yamllint has gained a new check which checks for inconsistent quoting
(mixed " and ' quotes within a file). Fix all the cases yamllint found
so we can enable the check (once the check is in a release). Use
whichever quoting is dominate in the file.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Thanks for your patch!

Since you are mentioning mixed quotes, is one or the other preferred?
I have a slight preference for single quotes.
Shouldn't we try to be consistent across all files?
I don't particularly care to change 915 files. And if the tools don't
enforce it, I'm not going to do so in reviews.
quoted
--- a/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
@@ -129,7 +129,7 @@ additionalProperties:

     - type: object
       additionalProperties:
-        $ref: "#/additionalProperties/anyOf/0"
+        $ref: '#/additionalProperties/anyOf/0'

 examples:
   - |
@@ -190,7 +190,7 @@ examples:

             sdhi0_pins: sd0 {
                     groups = "sdhi0_data4", "sdhi0_ctrl";
-                    function = "sdhi0";
+                    function = "sdhi0';
Huh?
One too many search and replace. Fixed.

Rob
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help