On 10/7/25 11:24, Wilfred Mallawa wrote:

On Tue, 2025-10-07 at 07:19 +0200, Hannes Reinecke wrote:

quoted

On 10/7/25 02:46, Wilfred Mallawa wrote:

quoted

From: Wilfred Mallawa <redacted>

[...]

quoted

I wonder: Do we really need to check for a partially assembled
record,
or wouldn't it be easier to call queue->write_space() every time
here?
We sure would end up with executing the callback more often, but if
no
data is present it shouldn't do any harm.

IE just use

if (nvme_tcp_queue_tls(queue)
      queue->write_space(sk);

Hey Hannes,

This was my initial approach, but I figured using
tls_is_partially_sent_record() might be slightly more efficient. But if
we think that's negligible, happy to go with this approach (omitting
the partial record check).

Please do.
Performance testing on NVMe-TCP is notoriously tricky, so for now we
really should not assume anything here.
And it's making the patch _vastly_ simpler, _and_ we don't have to
involve the networking folks here.
We have a similar patch for the data_ready() function in nvmet_tcp(),
and that seemed to work, too.
Nit: we don't unset the 'NOSPACE' flag there. Can you check if that's
really required? And, if it is, fixup nvmet_tcp() to unset it?
Or, if not, modify your patch to not clear it?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich