Thread (4 messages) 4 messages, 3 authors, 2025-09-25

Re: [PATCH net-next] dpll: zl3073x: Fix double free in zl3073x_devlink_flash_update()

From: Ivan Vecera <ivecera@redhat.com>
Date: 2025-09-25 05:14:44
Also in: kernel-janitors, lkml

On 23. 09. 25 1:13 odp., Dan Carpenter wrote:
quoted hunk ↗ jump to hunk
The zl3073x_devlink_flash_prepare() function calls zl3073x_fw_free()
and the caller also calls zl3073x_devlink_flash_update() so it leads
to a double free.  Delete the extra free.

Fixes: a1e891fe4ae8 ("dpll: zl3073x: Implement devlink flash callback")
Signed-off-by: Dan Carpenter <redacted>
---
  drivers/dpll/zl3073x/devlink.c | 1 -
  1 file changed, 1 deletion(-)
diff --git a/drivers/dpll/zl3073x/devlink.c b/drivers/dpll/zl3073x/devlink.c
index f55d5309d4f9..ccc22332b346 100644
--- a/drivers/dpll/zl3073x/devlink.c
+++ b/drivers/dpll/zl3073x/devlink.c
@@ -167,7 +167,6 @@ zl3073x_devlink_flash_prepare(struct zl3073x_dev *zldev,
  		zl3073x_devlink_flash_notify(zldev,
  					     "Utility is missing in firmware",
  					     NULL, 0, 0);
-		zl3073x_fw_free(zlfw);
  		return -ENOEXEC;
  	}
Thanks, Dan!

Reviewed-by: Ivan Vecera <ivecera@redhat.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help