[PATCH net-next] dpll: zl3073x: Fix double free in zl3073x_devlink_flash_update()
From: Dan Carpenter <hidden>
Date: 2025-09-23 11:13:06
Also in:
kernel-janitors, lkml
Subsystem:
dpll subsystem, microchip zl3073x driver, the rest · Maintainers:
Vadim Fedorenko, Arkadiusz Kubalewski, Jiri Pirko, Ivan Vecera, Prathosh Satish, Linus Torvalds
The zl3073x_devlink_flash_prepare() function calls zl3073x_fw_free()
and the caller also calls zl3073x_devlink_flash_update() so it leads
to a double free. Delete the extra free.
Fixes: a1e891fe4ae8 ("dpll: zl3073x: Implement devlink flash callback")
Signed-off-by: Dan Carpenter <redacted>
---
drivers/dpll/zl3073x/devlink.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/dpll/zl3073x/devlink.c b/drivers/dpll/zl3073x/devlink.c
index f55d5309d4f9..ccc22332b346 100644
--- a/drivers/dpll/zl3073x/devlink.c
+++ b/drivers/dpll/zl3073x/devlink.c@@ -167,7 +167,6 @@ zl3073x_devlink_flash_prepare(struct zl3073x_dev *zldev, zl3073x_devlink_flash_notify(zldev, "Utility is missing in firmware", NULL, 0, 0); - zl3073x_fw_free(zlfw); return -ENOEXEC; }
--
2.51.0