Thread (23 messages) 23 messages, 3 authors, 2025-09-17

Re: [PATCH v5 02/10] dt-bindings: clock: Add required "interconnect-cells" property

From: Krzysztof Kozlowski <hidden>
Date: 2025-09-12 09:16:17
Also in: linux-arm-kernel, linux-arm-msm, linux-clk, linux-devicetree, linux-pm, lkml

On 12/09/2025 11:13, Konrad Dybcio wrote:
On 9/12/25 9:04 AM, Krzysztof Kozlowski wrote:
quoted
On Tue, Sep 09, 2025 at 09:39:11PM +0800, Luo Jie wrote:
quoted
The Networking Subsystem (NSS) clock controller acts as both a clock
provider and an interconnect provider. The #interconnect-cells property
is mandatory in the Device Tree Source (DTS) to ensure that client
drivers, such as the PPE driver, can correctly acquire ICC clocks from
the NSS ICC provider.

Although this property is already present in the NSS CC node of the DTS
for CMN PLL for IPQ9574 SoC which is currently supported, it was previously
omitted from the list of required properties in the bindings documentation.
Adding this as a required property is not expected to break the ABI for
currently supported SoC.

Marking #interconnect-cells as required to comply with Device Tree (DT)
binding requirements for interconnect providers.
DT bindings do not require interconnect-cells, so that's not a correct
reason. Drop them from required properties.
"Mark #interconnect-cells as required to allow consuming the provided
interconnect endpoints"?

The point is they do not have to be required.

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help