On Fri, Sep 12, 2025 at 12:09 PM Muhammed Subair [off-list ref] wrote:

Hi

There are A527 boards with 25 Mhz clock from PH13 ( rgmii-0) and PJ10 (rgmii-1). See the attached .
I believe that a patch is required to support this. Not sure it can be a global or board specific.

This is board specific. If you have such a board you can send a patch
on top of this series for it.

ChenYu

Subair

-----Original Message-----
From: Chen-Yu Tsai <wens@kernel.org>
Sent: Thursday, 11 September 2025 10:18 PM
To: Russell King (Oracle) <linux@armlinux.org.uk>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>; David S. Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Jernej Skrabec <jernej@kernel.org>; Samuel Holland <samuel@sholland.org>; netdev@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-sunxi@lists.linux.dev; linux-kernel@vger.kernel.org; Andre Przywara <andre.przywara@arm.com>
Subject: Re: [PATCH net-next v4 02/10] net: stmmac: Add support for Allwinner A523 GMAC200

On Fri, Sep 12, 2025 at 2:09 AM Russell King (Oracle) [off-list ref] wrote:

quoted

Hi,

I drafted this but never sent it and can't remember why, but it's
relevant for v5 that you recently posted. Same concern with v5.

On Tue, Sep 09, 2025 at 02:10:51AM +0800, Chen-Yu Tsai wrote:

quoted

+     switch (plat->mac_interface) {
+     case PHY_INTERFACE_MODE_MII:
+             /* default */
+             break;
+     case PHY_INTERFACE_MODE_RGMII:
+     case PHY_INTERFACE_MODE_RGMII_ID:
+     case PHY_INTERFACE_MODE_RGMII_RXID:
+     case PHY_INTERFACE_MODE_RGMII_TXID:
+             reg |= SYSCON_EPIT | SYSCON_ETCS_INT_GMII;
+             break;
+     case PHY_INTERFACE_MODE_RMII:
+             reg |= SYSCON_RMII_EN;
+             break;
+     default:
+             return dev_err_probe(dev, -EINVAL, "Unsupported interface mode: %s",
+                                  phy_modes(plat->mac_interface));

I'm guessing that there's no way that plat->phy_interface !=
plat->mac_interface on this platform? If so, please use phy_interface
plat->here.

Makes sense. Looking at stmmac_platform.c, for us mac_interface only comes from phy_interface.

I'll wait a day before sending yet another version.

ChenYu