On Fri, Sep 12, 2025 at 2:09 AM Russell King (Oracle)
[off-list ref] wrote:

Hi,

I drafted this but never sent it and can't remember why, but it's
relevant for v5 that you recently posted. Same concern with v5.

On Tue, Sep 09, 2025 at 02:10:51AM +0800, Chen-Yu Tsai wrote:

quoted

+     switch (plat->mac_interface) {
+     case PHY_INTERFACE_MODE_MII:
+             /* default */
+             break;
+     case PHY_INTERFACE_MODE_RGMII:
+     case PHY_INTERFACE_MODE_RGMII_ID:
+     case PHY_INTERFACE_MODE_RGMII_RXID:
+     case PHY_INTERFACE_MODE_RGMII_TXID:
+             reg |= SYSCON_EPIT | SYSCON_ETCS_INT_GMII;
+             break;
+     case PHY_INTERFACE_MODE_RMII:
+             reg |= SYSCON_RMII_EN;
+             break;
+     default:
+             return dev_err_probe(dev, -EINVAL, "Unsupported interface mode: %s",
+                                  phy_modes(plat->mac_interface));

I'm guessing that there's no way that plat->phy_interface !=
plat->mac_interface on this platform? If so, please use
plat->phy_interface here.

Makes sense. Looking at stmmac_platform.c, for us mac_interface only comes
from phy_interface.

I'll wait a day before sending yet another version.

ChenYu