Hi Jakub,

On 10/09/2025 03:42, Jakub Kicinski wrote:

On Tue, 9 Sep 2025 11:08:46 +0200 Matthieu Baerts wrote:

quoted

quoted

Note that mptcp_pm_parse_entry has this, which should maybe be fixed at
the same time:

	u32 val = nla_get_s32(tb[MPTCP_PM_ADDR_ATTR_IF_IDX]);  

Good catch!

indeed!

quoted

This should be fixed in a dedicated patch, because this fixes commit:
ef0da3b8a2f1 ("mptcp: move address attribute into mptcp_addr_info"), a
different commit than the one being fixed here.

int = u32 is unlikely to cause issues AFAIU. We recently applied 
a bunch of such fixes to net-next. I think this can also go to -next.

Good point, in our tree, I will queue this patch for -next:


https://lore.kernel.org/20250909-mptcp-pm-user-c-flag-v2-1-a6f9542481c5@kernel.org (local)

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.