Thread (11 messages) 11 messages, 5 authors, 2025-09-10

Re: [PATCH net 1/3] netlink: specs: mptcp: fix if-idx attribute type

From: Jakub Kicinski <kuba@kernel.org>
Date: 2025-09-10 01:42:23
Also in: linux-doc, linux-kselftest, lkml, mptcp, stable

On Tue, 9 Sep 2025 11:08:46 +0200 Matthieu Baerts wrote:
quoted
Note that mptcp_pm_parse_entry has this, which should maybe be fixed at
the same time:

	u32 val = nla_get_s32(tb[MPTCP_PM_ADDR_ATTR_IF_IDX]);  
Good catch!
indeed!
This should be fixed in a dedicated patch, because this fixes commit:
ef0da3b8a2f1 ("mptcp: move address attribute into mptcp_addr_info"), a
different commit than the one being fixed here.
int = u32 is unlikely to cause issues AFAIU. We recently applied 
a bunch of such fixes to net-next. I think this can also go to -next.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help