Breno Leitao wrote:
Complete the SKB pool management refactoring by moving find_skb() from
netpoll core to netconsole driver, making it a static function.
This is the final step in removing SKB pool management from the generic
netpoll infrastructure. With this change:
1. Netpoll core is now purely transmission-focused: Contains only
the essential netpoll_send_skb() function for low-level packet
transmission, with no knowledge of SKB allocation or pool management.
2. Complete encapsulation in netconsole: All SKB lifecycle
management (allocation, pool handling, packet construction) is now
contained within the netconsole driver where it belongs.
3. Cleaner API surface: Removes the last SKB management export from
netpoll, leaving only zap_completion_queue() as a utility function
and netpoll_send_skb() for transmission.
4. Better maintainability: Changes to SKB allocation strategies or
pool management can now be made entirely within netconsole without
affecting the core netpoll infrastructure.
The find_skb() function is made static since it's now only used within
netconsole.c for its internal SKB allocation needs.
This completes the architectural cleanup that separates generic netpoll
transmission capabilities from console-specific resource management.
Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Willem de Bruijn <willemb@google.com>