Thread (12 messages) 12 messages, 4 authors, 2025-09-01

Re: [PATCH v3] icmp: fix icmp_ndo_send address translation for reply direction

From: patchwork-bot+netdevbpf@kernel.org
Date: 2025-09-01 20:20:06
Also in: netfilter-devel

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski [off-list ref]:

On Thu, 28 Aug 2025 11:14:35 +0200 you wrote:
The icmp_ndo_send function was originally introduced to ensure proper
rate limiting when icmp_send is called by a network device driver,
where the packet's source address may have already been transformed
by SNAT.

However, the original implementation only considers the
IP_CT_DIR_ORIGINAL direction for SNAT and always replaced the packet's
source address with that of the original-direction tuple. This causes
two problems:

[...]
Here is the summary with links:
  - [v3] icmp: fix icmp_ndo_send address translation for reply direction
    https://git.kernel.org/netdev/net/c/c6dd1aa2cbb7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help