Thread (12 messages) 12 messages, 4 authors, 2025-09-01

Re: [PATCH v3] icmp: fix icmp_ndo_send address translation for reply direction

From: Florian Westphal <fw@strlen.de>
Date: 2025-08-28 12:48:07
Also in: netfilter-devel

Pablo Neira Ayuso [off-list ref] wrote:
quoted
So I believe its needed, concurrent update of ->status is possible and
KCSAN would warn.  Other spots either use READ_ONCE or use test_bit().
There are a more checks for ct->status & NAT_MASK in the tree that I
can see, if you are correct, then maybe a new helper function to check
for NAT_MASK is needed.
I think it would make sense to add a helper, yes.
Independent of this patch of course.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help