Thread (16 messages) 16 messages, 3 authors, 2025-08-12

Re: [PATCH v2 net-next 12/12] net-memcg: Decouple controlled memcg from global protocol memory accounting.

From: kernel test robot <hidden>
Date: 2025-08-12 15:09:29
Also in: cgroups, linux-mm, mptcp, oe-kbuild-all

Hi Kuniyuki,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Kuniyuki-Iwashima/mptcp-Fix-up-subflow-s-memcg-when-CONFIG_SOCK_CGROUP_DATA-n/20250812-013522
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250811173116.2829786-13-kuniyu%40google.com
patch subject: [PATCH v2 net-next 12/12] net-memcg: Decouple controlled memcg from global protocol memory accounting.
config: csky-randconfig-002-20250812 (https://download.01.org/0day-ci/archive/20250812/202508122213.H31XXZsm-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 10.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250812/202508122213.H31XXZsm-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot [off-list ref]
| Closes: https://lore.kernel.org/oe-kbuild-all/202508122213.H31XXZsm-lkp@intel.com/ (local)

All errors (new ones prefixed by >>):

   In file included from include/linux/cleanup.h:5,
                    from include/linux/irqflags.h:17,
                    from include/asm-generic/cmpxchg.h:15,
                    from arch/csky/include/asm/cmpxchg.h:162,
                    from include/asm-generic/atomic.h:12,
                    from arch/csky/include/asm/atomic.h:199,
                    from include/linux/atomic.h:7,
                    from include/crypto/aead.h:11,
                    from net/tls/tls_device.c:32:
   net/tls/tls_device.c: In function 'tls_do_allocation':
quoted
net/tls/tls_device.c:374:8: error: implicit declaration of function 'sk_should_enter_memory_pressure'; did you mean 'tcp_enter_memory_pressure'? [-Werror=implicit-function-declaration]
     374 |    if (sk_should_enter_memory_pressure(sk))
         |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
      57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
         |                                                    ^~~~
   net/tls/tls_device.c:374:4: note: in expansion of macro 'if'
     374 |    if (sk_should_enter_memory_pressure(sk))
         |    ^~
   cc1: some warnings being treated as errors


vim +374 net/tls/tls_device.c

   363	
   364	static int tls_do_allocation(struct sock *sk,
   365				     struct tls_offload_context_tx *offload_ctx,
   366				     struct page_frag *pfrag,
   367				     size_t prepend_size)
   368	{
   369		int ret;
   370	
   371		if (!offload_ctx->open_record) {
   372			if (unlikely(!skb_page_frag_refill(prepend_size, pfrag,
   373							   sk->sk_allocation))) {
 > 374				if (sk_should_enter_memory_pressure(sk))
   375					READ_ONCE(sk->sk_prot)->enter_memory_pressure(sk);
   376				sk_stream_moderate_sndbuf(sk);
   377				return -ENOMEM;
   378			}
   379	
   380			ret = tls_create_new_record(offload_ctx, pfrag, prepend_size);
   381			if (ret)
   382				return ret;
   383	
   384			if (pfrag->size > pfrag->offset)
   385				return 0;
   386		}
   387	
   388		if (!sk_page_frag_refill(sk, pfrag))
   389			return -ENOMEM;
   390	
   391		return 0;
   392	}
   393	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help