quoted

On 28/08/2025 12:42, Ranganath V N wrote:
Currently the igb driver does not reports RX dropped
packets in the ethtool -S statistics output, even though
this information is already available in struct
rtnl_link_stats64.

This patch adds rx_dropped, so users can monitor dropped
packet counts directly with ethtool.

Signed-off-by: Ranganath V N <redacted>
---
  drivers/net/ethernet/intel/igb/igb_ethtool.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
index 92ef33459aec..3c6289e80ba0 100644
--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
+++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c

@@ -81,6 +81,7 @@ static const struct igb_stats igb_gstrings_stats[] = {
  }
  static const struct igb_stats igb_gstrings_net_stats[] = {
  	IGB_NETDEV_STAT(rx_errors),
+	IGB_NETDEV_STAT(rx_dropped),
  	IGB_NETDEV_STAT(tx_errors),
  	IGB_NETDEV_STAT(tx_dropped),
  	IGB_NETDEV_STAT(rx_length_errors),

This stat is never used in the igb driver, what's the benefit of
constant 0 value in the output?

Hi,
I initially proposed exposing it, but after reviewing 
the driver, I realized that stats.rx_dropped is never 
updated in igb. Exposing it would always show 0.

Ixgbe behaves the same: the counter is present 
but never incremented.But this patch wouldn't provide meaningful data.

Thanks again for your guidance.

Ranganath