RE: [Intel-wired-lan] [PATCH] net: igb: expose rx_dropped via ethtool -S
From: Loktionov, Aleksandr <hidden>
Date: 2025-08-28 15:48:59
Also in:
intel-wired-lan, linux-kernel-mentees, lkml
-----Original Message----- From: Intel-wired-lan <redacted> On Behalf Of Ranganath V N Sent: Thursday, August 28, 2025 1:42 PM To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel, Przemyslaw [off-list ref]; andrew+netdev@lunn.ch; davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org Cc: linux-kernel-mentees@lists.linuxfoundation.org; skhan@linuxfoundation.org; Ranganath V N [off-list ref] Subject: [Intel-wired-lan] [PATCH] net: igb: expose rx_dropped via ethtool -S Currently the igb driver does not reports RX dropped
Minor fix: s/reports/report/
packets in the ethtool -S statistics output, even though this information is already available in struct rtnl_link_stats64. This patch adds rx_dropped, so users can monitor dropped packet counts directly with ethtool.
Should it have Fixes: tag, what do you think?
Signed-off-by: Ranganath V N <redacted>
Looks good for me. Signed-off-by: Aleksandr Loktionov <redacted>
quoted hunk ↗ jump to hunk
--- drivers/net/ethernet/intel/igb/igb_ethtool.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.cb/drivers/net/ethernet/intel/igb/igb_ethtool.c index 92ef33459aec..3c6289e80ba0 100644--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c@@ -81,6 +81,7 @@ static const struct igb_stats igb_gstrings_stats[] ={ } static const struct igb_stats igb_gstrings_net_stats[] = { IGB_NETDEV_STAT(rx_errors), + IGB_NETDEV_STAT(rx_dropped), IGB_NETDEV_STAT(tx_errors), IGB_NETDEV_STAT(tx_dropped), IGB_NETDEV_STAT(rx_length_errors), -- 2.43.0