-----Original Message-----
From: Intel-wired-lan <redacted> On Behalf Of Simon
Horman
Sent: Wednesday, August 27, 2025 2:27 PM
To: Kohei Enju <redacted>
Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
kernel@vger.kernel.org; Nguyen, Anthony L [off-list ref];
Kitszel, Przemyslaw [off-list ref]; Andrew Lunn
[off-list ref]; David S. Miller [off-list ref]; Eric
Dumazet [off-list ref]; Jakub Kicinski [off-list ref]; Paolo
Abeni [off-list ref]; kohei.enju@gmail.com; Paul Menzel
[off-list ref]
Subject: Re: [Intel-wired-lan] [PATCH v2 iwl-next 1/2] igbvf: add lbtx_packets and
lbtx_bytes to ethtool statistics

On Tue, Aug 19, 2025 at 12:18:26AM +0900, Kohei Enju wrote:

quoted

Currently ethtool shows lbrx_packets and lbrx_bytes (Good RX
Packets/Octets loopback Count), but doesn't show the TX-side
equivalents (lbtx_packets and lbtx_bytes). Add visibility of those
missing statistics by adding them to ethtool statistics.

In addition, the order of lbrx_bytes and lbrx_packets is not
consistent with non-loopback statistics (rx_packets, rx_bytes).
Therefore, align the order by swapping positions of lbrx_bytes and lbrx_packets.

Tested on Intel Corporation I350 Gigabit Network Connection.

Before:
  # ethtool -S ens5 | grep -E "x_(bytes|packets)"
       rx_packets: 135
       tx_packets: 106
       rx_bytes: 16010
       tx_bytes: 12451
       lbrx_bytes: 1148
       lbrx_packets: 12

After:
  # ethtool -S ens5 | grep -E "x_(bytes|packets)"
       rx_packets: 748
       tx_packets: 304
       rx_bytes: 81513
       tx_bytes: 33698
       lbrx_packets: 97
       lbtx_packets: 109
       lbrx_bytes: 12090
       lbtx_bytes: 12401

Reviewed-by: Paul Menzel <redacted>
Signed-off-by: Kohei Enju <redacted>

Reviewed-by: Simon Horman <horms@kernel.org>

Tested-by: Rafal Romanowski <redacted>