RE: [Intel-wired-lan] [PATCH v2 iwl-next 2/2] igbvf: remove redundant counter rx_long_byte_count from ethtool statistics
From: Loktionov, Aleksandr <hidden>
Date: 2025-08-19 08:19:07
Also in:
intel-wired-lan, lkml
-----Original Message-----
From: Intel-wired-lan <redacted> On Behalf
Of Kohei Enju
Sent: Monday, August 18, 2025 5:18 PM
To: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
kernel@vger.kernel.org
Cc: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel,
Przemyslaw [off-list ref]; Andrew Lunn
[off-list ref]; David S. Miller [off-list ref]; Eric
Dumazet [off-list ref]; Jakub Kicinski [off-list ref]; Paolo
Abeni [off-list ref]; kohei.enju@gmail.com; Kohei Enju
[off-list ref]; Paul Menzel [off-list ref]
Subject: [Intel-wired-lan] [PATCH v2 iwl-next 2/2] igbvf: remove
redundant counter rx_long_byte_count from ethtool statistics
rx_long_byte_count shows the value of the GORC (Good Octets Received
Count) register. However, the register value is already shown as
rx_bytes and they always show the same value.
Remove rx_long_byte_count as the Intel ethernet driver e1000e did in
commit 0a939912cf9c ("e1000e: cleanup redundant statistics counter").
Tested on Intel Corporation I350 Gigabit Network Connection.
Reviewed-by: Paul Menzel <redacted>
Signed-off-by: Kohei Enju <redacted>Reviewed-by: Aleksandr Loktionov <redacted>
quoted hunk ↗ jump to hunk
--- drivers/net/ethernet/intel/igbvf/ethtool.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/net/ethernet/intel/igbvf/ethtool.cb/drivers/net/ethernet/intel/igbvf/ethtool.c index c6defc495f13..9c08ebfad804 100644--- a/drivers/net/ethernet/intel/igbvf/ethtool.c +++ b/drivers/net/ethernet/intel/igbvf/ethtool.c@@ -36,7 +36,6 @@ static const struct igbvf_statsigbvf_gstrings_stats[] = { { "lbtx_bytes", IGBVF_STAT(stats.gotlbc, stats.base_gotlbc) }, { "tx_restart_queue", IGBVF_STAT(restart_queue, zero_base) }, { "tx_timeout_count", IGBVF_STAT(tx_timeout_count, zero_base) }, - { "rx_long_byte_count", IGBVF_STAT(stats.gorc, stats.base_gorc) }, { "rx_csum_offload_good", IGBVF_STAT(hw_csum_good, zero_base) }, { "rx_csum_offload_errors", IGBVF_STAT(hw_csum_err, zero_base) }, { "rx_header_split", IGBVF_STAT(rx_hdr_split, zero_base) }, -- 2.48.1