Thread (24 messages) flat view 24 messages, 4 authors, 2025-09-21

Re: [PATCH v2 0/3] vhost_task: Fix a bug where KVM wakes an exited task

From: Lei Yang <hidden>
Date: 2025-08-28 02:43:28
Also in: kvm, lkml, virtualization

Tested this series of patches's v2 again with vhost-net regression
tests, everything works fine.

Tested-by: Lei Yang <redacted>

On Thu, Aug 28, 2025 at 4:11 AM Sebastian Andrzej Siewior
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
On 2025-08-27 12:41:04 [-0700], Sean Christopherson wrote:
quoted
Michael,
Sean,

would the bellow work by chance? It is a quick shot but it looks
symmetrical…
diff --git a/kernel/vhost_task.c b/kernel/vhost_task.c
index bc738fa90c1d6..27107dcc1cbfe 100644
--- a/kernel/vhost_task.c
+++ b/kernel/vhost_task.c
@@ -100,6 +100,7 @@ void vhost_task_stop(struct vhost_task *vtsk)
         * freeing it below.
         */
        wait_for_completion(&vtsk->exited);
+       put_task_struct(vtsk->task);
        kfree(vtsk);
 }
 EXPORT_SYMBOL_GPL(vhost_task_stop);
@@ -148,7 +149,7 @@ struct vhost_task *vhost_task_create(bool (*fn)(void *),
                return ERR_CAST(tsk);
        }

-       vtsk->task = tsk;
+       vtsk->task = get_task_struct(tsk);
        return vtsk;
 }
 EXPORT_SYMBOL_GPL(vhost_task_create);
Sebastian
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help