Re: [PATCH v5 4/5] net: rnpgbe: Add basic mbx_fw support
From: Yibo Dong <dong100@mucse.com>
Date: 2025-08-21 03:33:52
Also in:
linux-doc, lkml
From: Yibo Dong <dong100@mucse.com>
Date: 2025-08-21 03:33:52
Also in:
linux-doc, lkml
On Thu, Aug 21, 2025 at 05:13:27AM +0200, Andrew Lunn wrote:
quoted
'mucse_mbx_fw_post_req' is designed can be called by 'cat /sys/xxx',It is pretty unusual for ethernet drivers to export data in /sys, except via standard APIs, like statistics, carrier, address, opstate etc. I don't know how well the core will handle EINTR. It is not something most drivers do. -ETIMEDOUT is more likely when the firmware has crashed and does not respond in time. Do you have any operations which take a long time when things are working correctly? Andrew
'Update firmware operation' will take long time, maybe more than 10s. If user use 'ethtool -f' to update firmware, and ^C before done? If ^C before mucse_write_mbx, return as soon as possible. If after mucse_write_mbx, wait until fw true response.