Thread (58 messages) 58 messages, 4 authors, 2025-08-25

Re: [PATCH net-next v3 04/23] net: use zero value to restore rx_buf_len to default

From: Mina Almasry <hidden>
Date: 2025-08-19 00:07:21
Also in: io-uring, lkml

On Mon, Aug 18, 2025 at 6:56 AM Pavel Begunkov [off-list ref] wrote:
From: Jakub Kicinski <kuba@kernel.org>

Distinguish between rx_buf_len being driver default vs user config.
Use 0 as a special value meaning "unset" or "restore driver default".
This will be necessary later on to configure it per-queue, but
the ability to restore defaults may be useful in itself.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
I wonder if it should be extended to the other driver using
rx_buf_len, hns3. For that, I think the default buf size would be
HNS3_DEFAULT_RX_BUF_LEN.

Other than that, seems fine to me,

Reviewed-by: Mina Almasry <redacted>

-- 
Thanks,
Mina
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help