Thread (12 messages) flat view 12 messages, 3 authors, 2025-08-10

Re: [PATCH net] rds: Fix endian annotations across various assignments

From: Andrew Lunn <andrew@lunn.ch>
Date: 2025-08-10 20:20:08
Also in: linux-rdma, lkml

quoted
This smells of an LLM generated patch. So i think you are somewhat
wasting your time explaining in detail why this is wrong.
I have never used (and will not use) LLMs :(
Sorry, I need to refine my sense of smell.
P.S: I'm still learning the ropes as a contributor so please pardon my
ignorance.
You might find this interesting:

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

You made a few process errors as well. Since you submitted this to
net, it needs a Fixes: tag.

Also:

https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

Particularly:

	It must either fix a real bug that bothers people

Sparse warnings don't really both people. But is the sparse warning
indicating a read bug which does bother people? If so, net is O.K, but
please add to the commit message what the real bug is. If this is
simply cleanup, not a bug fix, please submit to net-next.

You can also learn a lot by subscribing to the netdev mailing list,
and reading other peoples patches, and review comments they get.

	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help