Re: [PATCH net v2] net: usbnet: Fix the wrong netif_carrier_on() call placement
From: Ammar Faizi <hidden>
Date: 2025-08-06 00:05:37
Also in:
linux-usb, lkml, stable
On Wed, Aug 06, 2025 at 06:56:20AM +0700, Ammar Faizi wrote:
Apart from moving it outside that if-statement, unlink_urbs() call should probably also be guarded as we agreed it makes no sense to call it when we're turning the link on.
Oh, no. I just realized, it does need to be guarded because if netif_carrier_on() is placed before the if (!netif_carrier_ok(dev->net)), it already clears __LINK_STATE_NOCARRIER. -- Ammar Faizi