On Tue, Aug 05, 2025 at 09:28:48PM +0100, Simon Horman wrote:

It seems this has escalated a bit as it broke things for Linus while
he was travelling. He tested this patch and it resolved the problem.
Which I think counts for something.

https://lore.kernel.org/netdev/CAHk-=wgkvNuGCDUMMs9bW9Mz5o=LcMhcDK_b2ThO6_T7cquoEQ@mail.gmail.com/ (local)

I have looked over the patch and it appears to me that it addresses a
straightforward logic error: a check was added to turn the carrier on only
if it is already on. Which seems a bit nonsensical. And presumably the
intention was to add the check for the opposite case.

This patch addresses that problem.

So let me try and nudge this on a bit by providing a tag.

Reviewed-by: Simon Horman <horms@kernel.org>

Hi Linus,

Given that Reviewed-by tag and the simplicity of the patch, it would be
great if you can take this patch sooner to your tree. The fix is very
critical for network connectivity. Especially for laptop users.

https://lore.kernel.org/all/20250801190310.58443-1-ammarfaizi2@gnuweeb.org/ (local)

-- 
Ammar Faizi