Re: [PATCH v3 09/27] dt-bindings: clock: mediatek: Describe MT8196 clock controllers

On 04/08/2025 16:15, AngeloGioacchino Del Regno wrote:

Il 04/08/25 15:58, Krzysztof Kozlowski ha scritto:

quoted

On 04/08/2025 15:27, AngeloGioacchino Del Regno wrote:

quoted

We discussed about aggregating votes, yes, in software - this instead is a
*broken* hardware that does the aggregation internally and does not require
nor want external drivers to do the aggregation.

quoted

Maybe it is just the name, so avoid all the confusing "votes" if this is
not voting system. If this is a voting system, then don't use custom
phandles.

Being it fundamentally *broken*, this being a voting system is what the hardware
initially wanted to be - but effectively, since it requires YOU to:
   - Make sure that power supplies are turned on, if not, turn them on by "touching"
     HW registers (so, without any assistance from the voter MCU), if any;
   - Turn on parent clocks manually, if any, before using the "voter mcu" to try
     to ungate that clock; and
     - Enable the "FENC" manually, after the mcu says that the clock was ungated.

I understand that "YOU" as Linux driver, when you want to do something
(e.g. toggle) a clock?

"you" == Linux driver, yes.

quoted

If so this looks a lot like power domain, although with some differences.

A power domain ungates power to something.

Does more, it is not a simple supply.

These are clocks, giving a (x) (M)Hz signal to something.

Your earlier message about "YOU" said:

"   - Make sure that power supplies are turned on, if not, turn them on
by "touching"
     HW registers (so, without any assistance from the voter MCU), if any;"

so not a simple clocks stuff.

Best regards,
Krzysztof