Thread (66 messages) 66 messages, 5 authors, 2025-08-06

Re: [RFC v1 21/22] net: parametrise mp open with a queue config

From: Jakub Kicinski <kuba@kernel.org>
Date: 2025-08-06 22:05:36
Also in: io-uring

On Wed, 6 Aug 2025 11:30:38 -0700 Mina Almasry wrote:
Sorry, I was disagreeing. The flow above seems complicated. I'm
probably missing something that requires this complication. I was
suggesting an approach I find more straightforward. 

Something like:
  nedev_config = get_driver_defaults()
  qcfg = get_driver_defaults()

  for each setting:
    if qcfg[i].X is set:
       use qcfg[i].X
    else
      use netdev_config.X
IMO the rules on when to override/update and reset qcfg[i].X will
get much more complicated than the extra `else if` in this logic.

Plus I suspect at some point we may want to add another layer here
for e.g. a group of queues delegated to the same container interface
(netkit, veth, ipvlan etc.) So I want to establish a clear model
rather than "optimize" for the number of u32 variables.

Most code (drivers) should never be exposed to any of this, they
consume a flattened qcfg for a reason.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help