Thread (6 messages) 6 messages, 3 authors, 2025-07-22

Re: [PATCH v2] can: tscan1: CAN_TSCAN1 can depend on PC104

From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2025-07-22 10:48:52
Also in: linux-can

On 20.07.2025 17:28:23, Randy Dunlap wrote:
Add a dependency on PC104 to limit (restrict) this driver kconfig
prompt to kernel configs that have PC104 set.

Add COMPILE_TEST as a possibility for more complete build coverage.
I tested this build config on x86_64 5 times without problems.
I've already Vincent's patch [1] on my tree.

[1] https://lore.kernel.org/all/20250715-can-compile-test-v2-3-f7fd566db86f@wanadoo.fr/ (local)

So this doesn't apply any more. Fixing the merge conflicts result in:

index ba16d7bc09ef..e061e35769bf 100644
--- a/drivers/net/can/sja1000/Kconfig
+++ b/drivers/net/can/sja1000/Kconfig
@@ -105,7 +105,7 @@ config CAN_SJA1000_PLATFORM
 
 config CAN_TSCAN1
         tristate "TS-CAN1 PC104 boards"
-        depends on ISA || (COMPILE_TEST && HAS_IOPORT)
+        depends on (ISA && PC104) || (COMPILE_TEST && HAS_IOPORT)
         help
           This driver is for Technologic Systems' TSCAN-1 PC104 boards.
           https://www.embeddedts.com/products/TS-CAN1
Should be ok?

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help