Re: [PATCH net-next] net/rose: Remove unnecessary if check in rose_dev_first()
From: Dan Carpenter <hidden>
Date: 2025-07-14 18:03:56
Also in:
linux-hams, lkml
On Fri, Jul 04, 2025 at 10:33:08AM +0200, Thorsten Blum wrote:
quoted hunk ↗ jump to hunk
dev_hold() already checks if its argument is NULL. Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> --- net/rose/rose_route.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/net/rose/rose_route.c b/net/rose/rose_route.c index b72bf8a08d48..35e21a2bec9c 100644 --- a/net/rose/rose_route.c +++ b/net/rose/rose_route.c@@ -608,8 +608,7 @@ struct net_device *rose_dev_first(void) if (first == NULL || strncmp(dev->name, first->name, 3) < 0) first = dev; } - if (first) - dev_hold(first); + dev_hold(first);
I'm not a fan of these sorts of "remove the NULL check" patches in general. Sure it removes a line of code, but does it really improve readability? I feel like someone reading this code might think a NULL check was required. I guess there is also an argument that this is a tiny speedup. That could be a valid argument especially if we had benchmarking data to back it up. Of course, if you're planning to take over this code and be the maintainer of it, then you get to do whatever you feel is best. So if this change were part of a larger change where you were taking over then that's fine. regards, dan carpenter