Re: [PATCH net-next] net/rose: Remove unnecessary if check in rose_dev_first()

On Fri, Jul 04, 2025 at 10:33:08AM +0200, Thorsten Blum wrote:

dev_hold() already checks if its argument is NULL.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>

Hi Thorsten,

I agree that this is correct. But I think that cleanup like this
needs to be in the context of other changes to make it worthwhile.

Quoting documentation:

  Clean-up patches
  ~~~~~~~~~~~~~~~~

  Netdev discourages patches which perform simple clean-ups, which are not in
  the context of other work. For example:

  * Addressing ``checkpatch.pl`` warnings
  * Addressing :ref:`Local variable ordering<rcs>` issues
  * Conversions to device-managed APIs (``devm_`` helpers)

  This is because it is felt that the churn that such changes produce comes
  at a greater cost than the value of such clean-ups.

  Conversely, spelling and grammar fixes are not discouraged.

See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches

--
pw-bot: cr