Re: [PATCH RFT net-next 02/10] net: stmmac: Add support for Allwinner A523 GMAC200

On Mon, Jul 07, 2025 at 11:06:55AM +0800, Chen-Yu Tsai wrote:

On Thu, Jul 3, 2025 at 4:19 PM Andrew Lunn [off-list ref] wrote:

quoted

quoted

+     if (!of_property_read_u32(node, "allwinner,tx-delay-ps", &val)) {

Please use the standard properties rx-internal-delay-ps and
tx-internal-delay-ps.

Since they share the same binding, I guess I either need to split the
binding so that the new compatible uses the standard properties, or
introduce them to the existing dwmac-sun8i driver as well?

You should get them for free from ethernet-controller.yaml. But you
might need to add a constraint that allwinner,tx-delay-ps etc is not
valid for this device.

	Andrew