On Thu, Jul 3, 2025 at 4:19 PM Andrew Lunn [off-list ref] wrote:
quoted
+ if (!of_property_read_u32(node, "allwinner,tx-delay-ps", &val)) {
Please use the standard properties rx-internal-delay-ps and
tx-internal-delay-ps.
Since they share the same binding, I guess I either need to split the
binding so that the new compatible uses the standard properties, or
introduce them to the existing dwmac-sun8i driver as well?
Please also ensure that if the property is missing, the default is
0ps.
This is already implied in this driver with the initial register value
being zero.
ChenYu