Re: [PATCH net v4 4/4] net: phy: bcm54811: Fix the PHY initialization
From: Florian Fainelli <florian.fainelli@broadcom.com>
Date: 2025-06-30 17:07:33
Also in:
linux-devicetree, lkml
On 6/30/25 06:58, Kamil Horák - 2N wrote:
Reset the bit 12 in PHY's LRE Control register upon initialization.
According to the datasheet, this bit must be written to zero after
every device reset.
Fixes: 03ab6c244bb0 ("net: phy: bcm-phy-lib: Implement BroadR-Reach link modes")
Signed-off-by: Kamil Horák - 2N <redacted>
---[snip]
quoted hunk ↗ jump to hunk
diff --git a/include/linux/brcmphy.h b/include/linux/brcmphy.h index 15c35655f482..115a964f3006 100644 --- a/include/linux/brcmphy.h +++ b/include/linux/brcmphy.h@@ -137,6 +137,7 @@ #define MII_BCM54XX_AUXCTL_SHDWSEL_MISC 0x07 #define MII_BCM54XX_AUXCTL_SHDWSEL_MISC_WIRESPEED_EN 0x0010 +#define MII_BCM54XX_AUXCTL_SHDWSEL_MISC_RSVD 0x0060 #define MII_BCM54XX_AUXCTL_SHDWSEL_MISC_RGMII_EN 0x0080 #define MII_BCM54XX_AUXCTL_SHDWSEL_MISC_RGMII_SKEW_EN 0x0100 #define MII_BCM54XX_AUXCTL_MISC_FORCE_AMDIX 0x0200
This register is not used in this patch or previous ones, please drop it, with that: Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> -- Florian