Re: [PATCH net-next 2/4] net: spacemit: Add K1 Ethernet MAC

From
Vivian Wang <hidden>
Date
2025-06-16 06:41:50
Also in
linux-devicetree, linux-riscv, lkml, spacemit
Reply to
Russell King (Oracle), 2025-06-16
Hi Russell,

Thanks for the review.

On 6/16/25 14:33, Russell King (Oracle) wrote:
On Fri, Jun 13, 2025 at 10:15:08AM +0800, Vivian Wang wrote:
quoted
+config SPACEMIT_K1_EMAC
+	tristate "SpacemiT K1 Ethernet MAC driver"
+	depends on ARCH_SPACEMIT || COMPILE_TEST
+	depends on MFD_SYSCON
+	depends on OF
+	default m if ARCH_SPACEMIT
+	select PHYLIB
This driver uses phylib...
quoted
+#include <linux/phy.h>
+#include <linux/phylink.h>
but includes phylink's header file? Does it use anything from this
header?
Thanks for the suggestion. I have misunderstood the purposes of some of
the header files. I will clean up #include lines in next version.

Regards,
Vivian "dramforever" Wang

Thread (14 messages) 14 messages, 7 authors, last reply 2025-06-16
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help