Re: [PATCH net-next 2/4] net: spacemit: Add K1 Ethernet MAC

From
Vivian Wang <hidden>
Date
2025-06-16 03:03:46
Also in
linux-devicetree, linux-riscv, lkml, spacemit
Reply to
Jakub Kicinski, 2025-06-13
Hi Jakub,

Thanks for your review.

On 6/13/25 21:31, Jakub Kicinski wrote:
On Fri, 13 Jun 2025 10:15:08 +0800 Vivian Wang wrote:
quoted
+	rx_ring->desc_addr = dma_alloc_coherent(&pdev->dev, rx_ring->total_size,
+						&rx_ring->desc_dma_addr,
+						GFP_KERNEL);
+	if (!rx_ring->desc_addr) {
+		kfree(rx_ring->rx_desc_buf);
+		return -ENOMEM;
+	}
+
+	memset(rx_ring->desc_addr, 0, rx_ring->total_size);
dma_alloc_coherent() already clears memory.
Thanks, I will remove memset in next version.

Regards,
Vivian "dramforever" Wang
Thread (14 messages) 14 messages, 7 authors, last reply 2025-06-16
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help