Thread (10 messages) 10 messages, 3 authors, 2025-06-24

Re: [PATCH iproute2-next v5 1/3] bridge: move mcast querier dumping code into a shared function

From: Ido Schimmel <idosch@nvidia.com>
Date: 2025-06-24 11:55:47
Also in: bridge

On Mon, Jun 23, 2025 at 11:33:16AM +0200, Fabian Pfitzner wrote:
Put mcast querier dumping code into a shared function. This function
will be called from the bridge utility in a later patch.

Adapt the code such that the vtb parameter is used
instead of tb[IFLA_BR_MCAST_QUERIER_STATE].

Signed-off-by: Fabian Pfitzner <redacted>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>

[...]
+void bridge_print_mcast_querier_state(const struct rtattr *vtb)
+{
+	struct rtattr *bqtb[BRIDGE_QUERIER_MAX + 1];
+
I assume you added the blank line because of checkpatch, but I think
it's wrong in this case.
+	SPRINT_BUF(other_time);
+
+	parse_rtattr_nested(bqtb, BRIDGE_QUERIER_MAX, vtb);
+	memset(other_time, 0, sizeof(other_time));
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help