Thread (13 messages) 13 messages, 6 authors, 2025-05-22

Re: [PATCH net-next 4/5] net/mlx5e: Don't drop RTNL during firmware flash

flat view

From: Jakub Kicinski <kuba@kernel.org>
Date: 2025-05-22 16:00:18
Also in: bpf, linux-rdma, lkml

On Wed, 21 May 2025 15:09:01 +0300 Tariq Toukan wrote:
However, the stack is moving towards netdev instance locking and
dropping and reacquiring RTNL in the context of flashing introduces
locking ordering issues: RTNL must be acquired before the netdev
instance lock and released after it.

This patch therefore takes the simpler approach by no longer dropping
and reacquiring the RTNL, as soon RTNL for ethtool will be removed,
leaving only the instance lock to protect against races.
You didn't mention it so just in case someone tries to report this 
as a regression later - devlink has been the preferred way to flash
devices for 5+ years. It has much better UX with the progress
notifications, and already does per-instance locking.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help