Re: [PATCH net-next 09/10] nvme-tcp: use crc32c() and skb_copy_and_crc32c_datagram_iter()
From: Sagi Grimberg <sagi@grimberg.me>
Date: 2025-05-17 20:32:40
Also in:
linux-nvme, linux-rdma, linux-sctp, lkml
if (queue->hdr_digest && !req->offset) - nvme_tcp_hdgst(queue->snd_hash, pdu, sizeof(*pdu)); + *(__le32 *)(pdu + 1) = nvme_tcp_hdgst(pdu, sizeof(*pdu));
I'd move this assignment to a helper nvme_tcp_set_hdgst(), especially as it has two call-sites. Other than that, Reviewed-by: Sagi Grimberg <sagi@grimberg.me