Re: [PATCH v3 1/4] net: airoha: Fix an error handling path in airoha_alloc_gdm_port()
From: Simon Horman <horms@kernel.org>
Date: 2025-05-16 20:17:16
Also in:
kernel-janitors, linux-arm-kernel, linux-mediatek, lkml
On Thu, May 15, 2025 at 11:16:56PM +0200, Lorenzo Bianconi wrote:
quoted
If register_netdev() fails, the error handling path of the probe will not free the memory allocated by the previous airoha_metadata_dst_alloc() call because port->dev->reg_state will not be NETREG_REGISTERED. So, an explicit airoha_metadata_dst_free() call is needed in this case to avoid a memory leak. Fixes: af3cf757d5c9 ("net: airoha: Move DSA tag in DMA descriptor") Signed-off-by: Christophe JAILLET <redacted>Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>