Re: [PATCH v3 1/4] net: airoha: Fix an error handling path in airoha_alloc_gdm_port()
From: Simon Horman <horms@kernel.org>
Date: 2025-05-16 20:16:11
Also in:
kernel-janitors, linux-arm-kernel, linux-mediatek, lkml
On Thu, May 15, 2025 at 09:59:35PM +0200, Christophe JAILLET wrote:
If register_netdev() fails, the error handling path of the probe will not
free the memory allocated by the previous airoha_metadata_dst_alloc() call
because port->dev->reg_state will not be NETREG_REGISTERED.
So, an explicit airoha_metadata_dst_free() call is needed in this case to
avoid a memory leak.
Fixes: af3cf757d5c9 ("net: airoha: Move DSA tag in DMA descriptor")
Signed-off-by: Christophe JAILLET <redacted>
---
Changes in v3:
- None
Changes in v2:
- New patch
v2: https://lore.kernel.org/all/5c94b9b3850f7f29ed653e2205325620df28c3ff.1746715755.git.christophe.jaillet@wanadoo.fr/ (local)
Compile tested only.Reviewed-by: Simon Horman <horms@kernel.org>