[PATCH v3 04/16] media: pci: cx18-av-vbi: Replace open-coded parity calculation with parity8()
From: Kuan-Wei Chiu <visitorckw@gmail.com>
Date: 2025-03-06 16:26:38
Also in:
bpf, dri-devel, linux-input, linux-media, linux-serial, linux-wireless, lkml
Subsystem:
cx18 video4linux driver, media input infrastructure (v4l/dvb), the rest · Maintainers:
Andy Walls, Mauro Carvalho Chehab, Linus Torvalds
Refactor parity calculations to use the standard parity8() helper. This change eliminates redundant implementations and improves code efficiency. Co-developed-by: Yu-Chun Lin <redacted> Signed-off-by: Yu-Chun Lin <redacted> Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com> --- drivers/media/pci/cx18/cx18-av-vbi.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/media/pci/cx18/cx18-av-vbi.c b/drivers/media/pci/cx18/cx18-av-vbi.c
index 65281d40c681..1a113aad9cd4 100644
--- a/drivers/media/pci/cx18/cx18-av-vbi.c
+++ b/drivers/media/pci/cx18/cx18-av-vbi.c@@ -8,6 +8,7 @@ */ +#include <linux/bitops.h> #include "cx18-driver.h" /*
@@ -56,15 +57,6 @@ struct vbi_anc_data { /* u8 fill[]; Variable number of fill bytes */ }; -static int odd_parity(u8 c) -{ - c ^= (c >> 4); - c ^= (c >> 2); - c ^= (c >> 1); - - return c & 1; -} - static int decode_vps(u8 *dst, u8 *p) { static const u8 biphase_tbl[] = {
@@ -278,7 +270,7 @@ int cx18_av_decode_vbi_line(struct v4l2_subdev *sd, break; case 6: sdid = V4L2_SLICED_CAPTION_525; - err = !odd_parity(p[0]) || !odd_parity(p[1]); + err = !parity8(p[0]) || !parity8(p[1]); break; case 9: sdid = V4L2_SLICED_VPS;
--
2.34.1