[PATCH v3 03/16] media: media/test_drivers: Replace open-coded parity calculation with parity8()
From: Kuan-Wei Chiu <visitorckw@gmail.com>
Date: 2025-03-06 16:26:27
Also in:
bpf, dri-devel, linux-input, linux-media, linux-serial, linux-wireless, lkml
Subsystem:
media input infrastructure (v4l/dvb), the rest, vivid virtual video driver · Maintainers:
Mauro Carvalho Chehab, Linus Torvalds, Hans Verkuil
Refactor parity calculations to use the standard parity8() helper. This change eliminates redundant implementations and improves code efficiency. Co-developed-by: Yu-Chun Lin <redacted> Signed-off-by: Yu-Chun Lin <redacted> Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com> --- drivers/media/test-drivers/vivid/vivid-vbi-gen.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/media/test-drivers/vivid/vivid-vbi-gen.c b/drivers/media/test-drivers/vivid/vivid-vbi-gen.c
index 70a4024d461e..e0f4151bda18 100644
--- a/drivers/media/test-drivers/vivid/vivid-vbi-gen.c
+++ b/drivers/media/test-drivers/vivid/vivid-vbi-gen.c@@ -5,6 +5,7 @@ * Copyright 2014 Cisco Systems, Inc. and/or its affiliates. All rights reserved. */ +#include <linux/bitops.h> #include <linux/errno.h> #include <linux/kernel.h> #include <linux/ktime.h>
@@ -165,12 +166,7 @@ static const u8 vivid_cc_sequence2[30] = { static u8 calc_parity(u8 val) { - unsigned i; - unsigned tot = 0; - - for (i = 0; i < 7; i++) - tot += (val & (1 << i)) ? 1 : 0; - return val | ((tot & 1) ? 0 : 0x80); + return val | (parity8(val) ? 0 : 0x80); } static void vivid_vbi_gen_set_time_of_day(u8 *packet)
--
2.34.1