Re: [PATCH v1 net-next 1/4] af_unix: Sort headers.
From: Kuniyuki Iwashima <hidden>
Date: 2025-03-18 23:52:19
From: Kuniyuki Iwashima <hidden>
Date: 2025-03-18 23:52:19
From: Joe Damato <redacted> Date: Tue, 18 Mar 2025 16:07:47 -0700
quoted
+#include <linux/in.h> #include <linux/init.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/mount.h> +#include <linux/namei.h> +#include <linux/net.h> +#include <linux/netdevice.h> #include <linux/poll.h> +#include <linux/proc_fs.h> #include <linux/rtnetlink.h> -#include <linux/mount.h> -#include <net/checksum.h> +#include <linux/sched/signal.h>Not sure what the sorting rules are, but I was wondering if maybe "linux/sched/*.h" should come after linux/*.h and not sorted within linux/s*.h ?
It's simply sorted in the alphabetial order. Actually I haven't cared about the / level, so I grepped the linux/sched/signal.h users and it looks like most didn't care. grep -rnI --include=*.c --include=*.h "linux/sched/signal.h" -C 3 Thanks!