Re: [PATCH v1 net-next 1/4] af_unix: Sort headers.
From: Joe Damato <hidden>
Date: 2025-03-18 23:07:50
On Mon, Mar 17, 2025 at 08:48:48PM -0700, Kuniyuki Iwashima wrote:
This is a prep patch to make the following changes cleaner. No functional change intended. Signed-off-by: Kuniyuki Iwashima <redacted> --- include/net/af_unix.h | 4 +-- net/unix/af_unix.c | 62 +++++++++++++++++++------------------- net/unix/diag.c | 15 ++++----- net/unix/garbage.c | 17 +++++------ net/unix/sysctl_net_unix.c | 1 - net/unix/unix_bpf.c | 4 +-- 6 files changed, 51 insertions(+), 52 deletions(-)
[...]
quoted hunk ↗ jump to hunk
diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index 7f8f3859cdb3..1ff0ac99f3f3 100644 --- a/net/unix/af_unix.c +++ b/net/unix/af_unix.c
[...]
+#include <linux/in.h> #include <linux/init.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/mount.h> +#include <linux/namei.h> +#include <linux/net.h> +#include <linux/netdevice.h> #include <linux/poll.h> +#include <linux/proc_fs.h> #include <linux/rtnetlink.h> -#include <linux/mount.h> -#include <net/checksum.h> +#include <linux/sched/signal.h>
Not sure what the sorting rules are, but I was wondering if maybe "linux/sched/*.h" should come after linux/*.h and not sorted within linux/s*.h ?
#include <linux/security.h> +#include <linux/seq_file.h> +#include <linux/signal.h> +#include <linux/skbuff.h> +#include <linux/slab.h> +#include <linux/socket.h> +#include <linux/sockios.h>