Re: [PATCH net-next v3 06/14] motorcomm:yt6801: Implement the fxgmac_start function
From: Andrew Lunn <andrew@lunn.ch>
Date: 2025-02-28 14:10:18
Also in:
lkml
+static int fxgmac_phy_connect(struct fxgmac_pdata *priv)
+{
+ struct phy_device *phydev = priv->phydev;
+ int ret;
+
+ priv->phydev->irq = PHY_POLL;
+ ret = phy_connect_direct(priv->netdev, phydev, fxgmac_phylink_handler,
+ PHY_INTERFACE_MODE_INTERNAL);
+ if (ret)
+ return ret;
+
+ phy_support_asym_pause(phydev);
+ priv->phydev->mac_managed_pm = 1;
+ phy_attached_info(phydev);
+
+ return 0;
+}Please consider swapping to phylink, not phylib. Your current pause implementation is broken, which is a common problem with drivers using phylib. phylink makes it much harder to get pause wrong. The same can be said for EEE, if you decide to implement it. Andrew