Re: [PATCH net-next 3/7] net: hibmcge: Add rx checksum offload supported in this module

on 2025/2/18 21:42, Simon Horman wrote:

On Tue, Feb 18, 2025 at 04:27:28PM +0800, Jijie Shao wrote:

quoted

on 2025/2/18 10:46, Kalesh Anakkur Purayil wrote:

quoted

On Tue, Feb 18, 2025 at 7:47 AM Jijie Shao [off-list ref] wrote:

quoted

on 2025/2/17 23:40, Simon Horman wrote:

quoted

On Thu, Feb 13, 2025 at 11:55:25AM +0800, Jijie Shao wrote:

quoted

This patch implements the rx checksum offload feature
including NETIF_F_IP_CSUM NETIF_F_IPV6_CSUM and NETIF_F_RXCSUM

Signed-off-by: Jijie Shao <shaojijie@huawei.com>

...

quoted

diff --git a/drivers/net/ethernet/hisilicon/hibmcge/hbg_txrx.c b/drivers/net/ethernet/hisilicon/hibmcge/hbg_txrx.c
index 8c631a9bcb6b..aa1d128a863b 100644
--- a/drivers/net/ethernet/hisilicon/hibmcge/hbg_txrx.c
+++ b/drivers/net/ethernet/hisilicon/hibmcge/hbg_txrx.c

@@ -202,8 +202,11 @@ static int hbg_napi_tx_recycle(struct napi_struct *napi, int budget)
    }

    static bool hbg_rx_check_l3l4_error(struct hbg_priv *priv,
-                                struct hbg_rx_desc *desc)
+                                struct hbg_rx_desc *desc,
+                                struct sk_buff *skb)
    {
+    bool rx_checksum_offload = priv->netdev->features & NETIF_F_RXCSUM;

nit: I think this would be better expressed in a way that
        rx_checksum_offload is assigned a boolean value (completely untested).

        bool rx_checksum_offload = !!(priv->netdev->features & NETIF_F_RXCSUM);

Okay, I'll modify it in v2.

Maybe you can remove " in this module" from the patch title as it is
implicit. This comment/suggestion applies to all patches in this
series.

Sorry this may not have any bad effect,
so I don't plan to change it in V2.
If anyone else thinks it should be modified,
I will modify it.

I agree that a shorter subject would be better.

ok,
v2 has been sent, I'll modify it if need to send v3.

Thanks,
Jijie Shao