Thread (24 messages) 24 messages, 4 authors, 2025-02-19

Re: [PATCH net-next 5/7] net: hibmcge: Add mac link exception handling feature in this module

From: Andrew Lunn <andrew@lunn.ch>
Date: 2025-02-13 20:05:15
Also in: lkml

+int hbg_reset_phy(struct hbg_priv *priv)
+{
+	struct phy_device *phydev = priv->mac.phydev;
+
+	if (phydev->drv->soft_reset)
+		return phydev->drv->soft_reset(phydev);
+
+	return genphy_soft_reset(phydev);
+}
A MAC driver should not be doing a soft reset on a PHY. For some
devices, this clears out all the settings. I would suggest you use
phy_stop(), phy_start() which are functions a MAC driver is allowed to
use.

	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help