Thread (7 messages) 7 messages, 4 authors, 2025-02-20

Re: [PATCH v17 1/1] mctp pcc: Implement MCTP over PCC Transport

From: Jeremy Kerr <jk@codeconstruct.com.au>
Date: 2025-02-06 07:04:05
Also in: lkml

Hi Adam,

One minor note below if you end up re-rolling for other reasons, but
regardless of that:

Acked-by: Jeremy Kerr <jk@codeconstruct.com.au>
+       /* ndev needs to be freed before the iomemory (mapped above) gets
+        * unmapped,  devm resources get freed in reverse to the order they
+        * are added.
+        */
+       rc = mctp_register_netdev(ndev, &mctp_netdev_ops, MCTP_PHYS_BINDING_PCC);
+       if (rc)
+               goto cleanup_netdev;
+       return  devm_add_action_or_reset(dev, mctp_cleanup_netdev, ndev);
You seem to have a trigger-happy spacebar; there is another double-space
creeping in here, after the 'return'.

Cheers,


Jeremy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help