Re: [PATCH net-next v3 2/2] net: plumb extack in __dev_change_net_namespace()

On Thu, Feb 20, 2025 at 2:22 PM Nicolas Dichtel
[off-list ref] wrote:

Le 20/02/2025 à 14:17, Eric Dumazet a écrit :

quoted

On Thu, Feb 20, 2025 at 2:03 PM Nicolas Dichtel
[off-list ref] wrote:

quoted

It could be hard to understand why the netlink command fails. For example,
if dev->netns_local is set, the error is "Invalid argument".

After your patch, a new message is : "  "The interface has the 'netns
local' property""

Honestly, I am not sure we export to user space the concept of 'netns local'

"This interface netns is not allowed to be changed" or something like that ?

Frankly, I was hesitating. I used 'netns local' to ease the link with the new
netlink attribute, and with what was displayed by ethtool for a long time.
I don't have a strong opinion about this.

No strong opinion either, I always have been confused by NETNS_LOCAL choice.

Reviewed-by: Eric Dumazet <edumazet@google.com>