Re: [PATCH] net: mvneta: fix locking in mvneta_cpu_online()
From: Simon Horman <horms@kernel.org>
Date: 2025-01-21 09:53:56
Also in:
kernel-janitors, lkml
On Mon, Jan 20, 2025 at 04:50:02PM -0800, Harshit Mogalapalli wrote:
When port is stopped, unlock before returning
Fixes: 413f0271f396 ("net: protect NAPI enablement with netdev_lock()")
Signed-off-by: Harshit Mogalapalli <redacted>
---
This is based on static analysis, only compile testedThanks Harshit, I agree that this is correct. FWIIW, I would have used the idiomatic approach of a goto to jump to nearly the end of the function, but the effect is the same either way. Reviewed-by: Simon Horman <horms@kernel.org>