Re: [PATCH] net: mvneta: fix locking in mvneta_cpu_online()
From: Harshit Mogalapalli <hidden>
Date: 2025-01-21 00:53:40
Also in:
kernel-janitors, lkml
Hi, On 21/01/25 06:20, Harshit Mogalapalli wrote:
When port is stopped, unlock before returning
Missed adding a period at the end of sentence. Should I send a V2 ? Thanks, Harshit
quoted hunk ↗ jump to hunk
Fixes: 413f0271f396 ("net: protect NAPI enablement with netdev_lock()") Signed-off-by: Harshit Mogalapalli <redacted> --- This is based on static analysis, only compile tested --- drivers/net/ethernet/marvell/mvneta.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index 82f4333fb426..4fe121b9f94b 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c@@ -4432,6 +4432,7 @@ static int mvneta_cpu_online(unsigned int cpu, struct hlist_node *node) */ if (pp->is_stopped) { spin_unlock(&pp->lock); + netdev_unlock(port->napi.dev); return 0; } netif_tx_stop_all_queues(pp->dev);