Re: [PATCH v3 05/10] ARM: dts: aspeed: system1: Add RGMII support

From
Ninad Palsule <ninad@linux.ibm.com>
Date
2025-01-13 19:52:22
Also in
linux-arm-kernel, linux-aspeed, linux-devicetree, lkml
Reply to
Andrew Lunn, 2025-01-08
Hi Andrew,

On 1/8/25 11:03, Andrew Lunn wrote:
On Wed, Jan 08, 2025 at 10:36:33AM -0600, Ninad Palsule wrote:
quoted
system1 has 2 transceiver connected through the RGMII interfaces. Added
device tree entry to enable RGMII support.

ASPEED AST2600 documentation recommends using 'rgmii-rxid' as a
'phy-mode' for mac0 and mac1 to enable the RX interface delay from the
PHY chip.
You appear to if ignored my comment. Please don't do that. If you have
no idea about RGMII delays, please say so, so i can help you debug
what is wrong.

NACK

	Andrew
Thanks for the review. I have dropped this patch from version 4 until Jacky fixes the driver.

Regards,

Ninad
Thread (27 messages) 27 messages, 4 authors, last reply 2025-01-14
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help